Generate supplemental RPM packages - #1147
Open
cpuguy83 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds RPM generation for target-level supplemental packages sharing the primary build output.
Changes:
- Generates RPM subpackage metadata, artifacts, dependencies, and scriptlets.
- Refactors shared artifact installation and scriptlet generation.
- Adds template and LLB-level tests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
packaging/linux/rpm/template.go |
Generates supplemental RPM sections and artifacts. |
packaging/linux/rpm/template_test.go |
Tests generated subpackage specifications. |
packaging/linux/rpm/buildroot_test.go |
Tests generated RPM-spec LLB operations. |
cpuguy83
force-pushed
the
subpackage-rpm
branch
3 times, most recently
from
July 17, 2026 19:13
117864c to
5f87907
Compare
invidian
approved these changes
Jul 20, 2026
invidian
left a comment
invidian
left a comment
Contributor
There was a problem hiding this comment.
Some minor comments, but LGTM overall. I did not analyze test coverage in depth, I assume it's sufficient.
| {{ .PreUn -}} | ||
| {{ .PostUn -}} | ||
| {{ .Files -}} | ||
| {{ .SubPackages -}} |
Contributor
There was a problem hiding this comment.
With this amount of string builder code, have we tried leveraging templates more instead of string builder? Maybe it would make things more readable? Right now all this code here is rather hard to follow tbh.
Collaborator
Author
There was a problem hiding this comment.
I think its something we could take a look at.
Templates have their own trade-off/readability issues, though.
cpuguy83
force-pushed
the
subpackage-model
branch
from
July 20, 2026 17:53
4cfdccd to
9c8bdcb
Compare
cpuguy83
force-pushed
the
subpackage-model
branch
2 times, most recently
from
July 20, 2026 17:55
6d192e0 to
a20af72
Compare
cpuguy83
force-pushed
the
subpackage-rpm
branch
2 times, most recently
from
July 20, 2026 22:33
5d94f50 to
5de2413
Compare
Add SubPackages() method and supporting types to produce %package, %description, %files, and scriptlet sections for each supplemental package. Refactor Install() to include subpackage artifacts in the shared %install section. Includes comprehensive template-level tests. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds RPM subpackage sections, artifact selection, and scriptlets, with template and LLB-level coverage.
This is layer 2 of the native supplemental-packages stack and depends on #1146.
Related to #607.